milleruntime commented on pull request #1803: URL: https://github.com/apache/accumulo/pull/1803#issuecomment-761068173
I think I figured out the issue with this change. The problem is with how `RecoveryManager.recoverLogs()` works. The first time the Master will call `RecoveryManager.recoverLogs()` it will generate `dest` (call it dest1) using `RecoveryPath.getRecoveryPath()`. RecoveryManager will check for a "finished" file at this location, which won't exist yet and kick off the log sorting process. The LogSorter job will complete and put a "finished" marker at dest1. The next time the Master tries to assign the Tablet, it will call `RecoveryManager.recoverLogs()` and generate a second `dest` (call it dest2). RecoveryManager will check for a "finished" file at dest2, won't see it and start another log sort process. The "finished" file is never seen by the next call of `RecoveryManager.recoverLogs()` and the log sorting process will continue indefinitely. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
