EdColeman commented on a change in pull request #1890:
URL: https://github.com/apache/accumulo/pull/1890#discussion_r566974481
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/BulkImportCacheCleaner.java
##########
@@ -54,9 +54,13 @@ public void run() {
for (Tablet tablet : server.getOnlineTablets().values()) {
tablet.cleanupBulkLoadedFiles(tids);
}
- } catch (KeeperException | InterruptedException e) {
+ } catch (KeeperException e) {
// we'll just clean it up again later
- log.debug("Error reading bulk import live transactions {}", e);
+ log.debug("Error reading bulk import live transactions {}", tids, e);
+ } catch (InterruptedException e) {
+ // propagate the interrupt status.
+ Thread.currentThread().interrupt();
+ log.debug("Interrupted while reading bulk import live transactions {}",
tids, e);
Review comment:
Sorry should have considered this - but might want to consider bumping
up the log level - we really shouldn't be seeing interrupts and if the keep
reoccurring and are not being handled, then we should dig deeper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
