brianloss commented on a change in pull request #1891:
URL: https://github.com/apache/accumulo/pull/1891#discussion_r567308594
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java
##########
@@ -56,7 +56,11 @@
* Implementations may wish to store configuration in Accumulo's system
configuration using the
* {@link Property#GENERAL_ARBITRARY_PROP_PREFIX}. They may also benefit from
using per-table
* configuration using {@link Property#TABLE_ARBITRARY_PROP_PREFIX}.
+ *
+ * @deprecated since 2.1.0. Use {@link
org.apache.accumulo.core.spi.balancer.TabletBalancer}
+ * instead.
*/
+@Deprecated(since = "2.1.0")
public abstract class TabletBalancer {
Review comment:
I think that could be done. The main downside I can think of is that,
when using the deprecated balancer, the params to getAssignments and balance
would get converted to the new types in the master and then converted back to
the thrift types in the implementation of the SPI TabletBalancer methods that
then delegate to the deprecated TabletBalancer methods. I don't think the
balancer methods are called often enough that we really need to worry about the
performance hit, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
