ctubbsii commented on a change in pull request #1892:
URL: https://github.com/apache/accumulo/pull/1892#discussion_r568087543
##########
File path:
test/src/main/java/org/apache/accumulo/test/BulkImportMonitoringIT.java
##########
@@ -65,15 +67,21 @@ protected void configure(MiniAccumuloConfigImpl cfg,
Configuration hadoopCoreSit
public void test() throws Exception {
getCluster().getClusterControl().start(ServerType.MONITOR);
try (AccumuloClient c =
Accumulo.newClient().from(getClientProperties()).build()) {
+
+ // creating table name
final String tableName = getUniqueNames(1)[0];
- c.tableOperations().create(tableName);
- c.tableOperations().setProperty(tableName,
Property.TABLE_MAJC_RATIO.getKey(), "1");
- // splits to slow down bulk import
+ // creating splits
SortedSet<Text> splits = new TreeSet<>();
for (int i = 1; i < 0xf; i++) {
splits.add(new Text(Integer.toHexString(i)));
}
Review comment:
> Regardless, I don't think its fair for @DomGarguilo to include this as
part of the code review.
Part of this issue seems to be about standardizing the way split points are
created in our tests. My suggestion (or some variant) could be included as a
part of that, or as a follow on PR, or not at all. It is merely a suggestion,
in case they want to consider it. Whether it is included or not, I leave to
their discretion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
