ctubbsii commented on a change in pull request #1907:
URL: https://github.com/apache/accumulo/pull/1907#discussion_r570304567



##########
File path: core/src/main/thrift/manager.thrift
##########
@@ -213,7 +213,7 @@ service FateService {
 
 }
 
-service MasterClientService extends FateService {

Review comment:
       Wire compatibility is definitely broken between 2.0 and 2.1 for 
server-to-server communication (preventing rolling upgrades, for example), but 
I don't know that we have any explicit check to determine client-to-server wire 
compatibility. So, it may or may not be broken. I'm not sure.
   
   I'm okay with breaking it... if we document that in the release notes. I 
just want to ensure we are noticing the consequences and accepting the risks as 
we go.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to