brianloss commented on a change in pull request #1912:
URL: https://github.com/apache/accumulo/pull/1912#discussion_r571213979
##########
File path: core/src/main/java/org/apache/accumulo/core/Constants.java
##########
@@ -42,11 +42,11 @@
public static final String ZNAMESPACE_NAME = "/name";
public static final String ZNAMESPACE_CONF = "/conf";
- public static final String ZMASTERS = "/masters";
- public static final String ZMASTER_LOCK = ZMASTERS + "/lock";
- public static final String ZMASTER_GOAL_STATE = ZMASTERS + "/goal_state";
- public static final String ZMASTER_REPLICATION_COORDINATOR_ADDR = ZMASTERS +
"/repl_coord_addr";
- public static final String ZMASTER_TICK = ZMASTERS + "/tick";
+ public static final String ZMANAGERS = "/masters";
Review comment:
From a ZK upgrade, I believe it's straightforward--do a recursive copy
of /masters to /managers and then delete /masters. However, the existing
upgrader runs inside the manager which won't start because the accumulo-service
script invokes
[SetGoalState](https://github.com/apache/accumulo/blob/main/assemble/bin/accumulo-service#L72)
first and that hangs. I suppose I could add a check in SetGoalState to do the
upgrade if /masters exists and /managers doesn't. Not sure if that makes sense
or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
