ctubbsii commented on a change in pull request #1912: URL: https://github.com/apache/accumulo/pull/1912#discussion_r572634175
########## File path: server/manager/src/main/java/org/apache/accumulo/manager/upgrade/RenameMasterDirInZK.java ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.manager.upgrade; + +import org.apache.accumulo.core.Constants; +import org.apache.accumulo.core.conf.SiteConfiguration; +import org.apache.accumulo.fate.zookeeper.ZooReaderWriter; +import org.apache.accumulo.fate.zookeeper.ZooUtil; +import org.apache.accumulo.server.ServerContext; +import org.apache.zookeeper.KeeperException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * A utility to handle the renaming of "/masters" to "/managers" in Zookeeper when upgrading from a + * 2.0 (or earlier) to 2.1 instance. This utility is invoked automatically by + * {@link org.apache.accumulo.manager.state.SetGoalState} (which normally runs first as a part of + * accumulo startup scripts). However, if a user is not using the standard scripts or wishes to + * perform the upgrade as a separate process, this utility can be invoked with: + * Review comment: This is fine, but will definitely need a mention in the release notes. FWIW, if 2.1 is an LTM release (and I think it should be), we won't need to keep this around, because we only need to support upgrades from the last LTM to the next. ########## File path: server/manager/src/main/java/org/apache/accumulo/manager/tableOps/namespace/create/CreateNamespace.java ########## @@ -44,11 +44,11 @@ public long isReady(long tid, Manager environment) { } @Override - public Repo<Manager> call(long tid, Manager master) throws Exception { + public Repo<Manager> call(long tid, Manager manager) throws Exception { Review comment: Most of these FaTE RepOs could just use the name "env". Some of them already do that. But this is fine, too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
