keith-turner commented on pull request #1917:
URL: https://github.com/apache/accumulo/pull/1917#issuecomment-776188404


   >> We are throwing `IllegalArgumentException`.
   >> `java.lang.IllegalArgumentException: File name test2743857433138030645 
has no extension`
   >> `java.lang.IllegalArgumentException: File type dat not supported`
   >
   >Where is that being thrown? I think @keith-turner suggested we throw it in 
the builder's `to` method, which I agree would >be great.
   
   The to method may be nice, I was more concerned about an actionable error 
message.  I think this those messages could be improved to mention the expected 
extension.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to