ctubbsii commented on a change in pull request #1918:
URL: https://github.com/apache/accumulo/pull/1918#discussion_r573414461
##########
File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java
##########
@@ -222,10 +222,7 @@ public int compare(String o1, String o2) {
}
});
}
- if (LOG.isDebugEnabled()) {
- LOG.debug("Children nodes: {}", validChildren.size());
- validChildren.forEach(c -> LOG.debug("- {}", c));
- }
+ LOG.trace("Children nodes (size: {}): {}", validChildren.size(),
validChildren);
Review comment:
> Keeping the original format may be easier to read in the logs.
In the extremely rare cases somebody is going to enable trace logging to
debug something, I think it'd be pretty easy to take the string form of the
List type and convert it to a more readable form, if they really need to. Also,
there's no guarantee about ordering of log messages in the logger framework, so
these can easily be split up by other messages or ordered in strange ways by
the time they make it to a log file. Keeping it in one line eliminates any
uncertainty with regard to that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
