milleruntime commented on a change in pull request #1927: URL: https://github.com/apache/accumulo/pull/1927#discussion_r574543016
########## File path: server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader9to10.java ########## @@ -95,7 +95,17 @@ import com.google.common.base.Preconditions; /** - * Handles upgrading from 2.0 to 2.1 + * Handles upgrading from 2.0 to 2.1. + * <ul> + * <li><strong>Rename master properties (Issue + * <a href="https://github.com/apache/accumulo/issues/1640";>#1640</a>):</strong> Rename any + * ZooKeeper system properties that start with "master." to the equivalent property starting with + * "manager." instead (see the {@code renameOldMasterPropsinZK(ServerContext)} method). Note that Review comment: I am not sure which spot in the javadoc is more likely for users to see (at the class or method) but you could link to the method like this: ```suggestion * "manager." instead (see the {@link #renameOldMasterPropsinZK(ServerContext)} method). Note that ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
