ctubbsii commented on pull request #1910: URL: https://github.com/apache/accumulo/pull/1910#issuecomment-786013267
> As part of https://issues.apache.org/jira/browse/ACCUMULO-1399 I added the ability for users to write scripts in a supported JSR-223 engine and run them in the shell. How does adding jshell to the shell compare to this? Is it duplicative, should the script command be deprecated? @dlmarion Rhino, the default scripting engine that feature used is already removed from Java, and replaced with Nashorn, which is now also deprecated and scheduled for removal in JDK 15. So, that feature won't work anymore anyway. So, yes, that script command should be deprecated. I don't know all the use cases for the shell script command, but I suspect that they can all be replaced with the use of JShell. JShell is even better, actually, because it can be used interactively. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
