ctubbsii commented on a change in pull request #1910:
URL: https://github.com/apache/accumulo/pull/1910#discussion_r583745312
##########
File path: assemble/bin/accumulo
##########
@@ -58,6 +58,18 @@ function main() {
echo "$CLASSPATH"
exit 0
fi
+
+ # Set up path variable for default import config file
+ export jShellPath="$conf/jshell-init.jsh"
+
+ if [[ $cmd == "jshell" ]]; then
+ shift
+ if [[ -f "$jShellPath" ]]; then
+ exec "$cmd" --startup DEFAULT "$jShellPath" "$@"
Review comment:
I was aware of the workaround, but it's still annoying to specify the
fully-qualified class name. Since the java.util.Scanner is very unlikely to be
used by Accumulo devs using this, I was thinking we could try to exclude it by
replacing `java.util.*` from the defaults with a narrower set of useful imports
from `java.util`, but I'm not sure what that set would look like. It would
probably include a bunch of Collection classes, but I'm not sure what else.
The alternative is that we just settle for the workaround for now, and
consider a new name for Scanner in Accumulo's public API in the future to make
it easier to coexist with java.util.Scanner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
