ctubbsii commented on a change in pull request #1958:
URL: https://github.com/apache/accumulo/pull/1958#discussion_r588482626
##########
File path:
core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooQueueLock.java
##########
@@ -32,7 +33,7 @@
public class ZooQueueLock implements QueueLock {
- private static final String PREFIX = "lock-";
+ private static final String PREFIX = "zlock#" + UUID.randomUUID() + "#";
Review comment:
Constants.java has slowly been in the process of being phased out, as
constants move closer to the code that is responsible for them, under the
premise that fewer global constants increase modularity and separation of
responsibilities.
If the schema is defined by ZooLock and ZooQueueLock is trying to match it,
then the constant should live in ZooLock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
