ctubbsii commented on a change in pull request #1970:
URL: https://github.com/apache/accumulo/pull/1970#discussion_r593849904
##########
File path:
shell/src/main/java/org/apache/accumulo/shell/commands/ScriptCommand.java
##########
@@ -197,7 +206,7 @@ private void putConnector(Bindings b, AccumuloClient
client) {
@Override
public String description() {
- return "execute JSR-223 scripts";
+ return "This is will be deprecated and will be replaced by Java 11's
JShell Feature - execute JSR-223 scripts";
Review comment:
If I remember correctly, these command descriptions are used by the
Shell to generate it's built-in `help` documentation. Therefore, the
description style should flow well in that context. Have you tried running the
`bin/accumulo shell` to test this description in the help context?
##########
File path:
shell/src/main/java/org/apache/accumulo/shell/commands/ScriptCommand.java
##########
@@ -68,6 +74,9 @@
public int execute(String fullCommand, CommandLine cl, Shell shellState)
throws Exception {
boolean invoke = false;
+
+ Shell.log.warn(
+ "Deprecated -- much of the use case for having this script command is
likely able to be replaced by Java 11's JShell feature");
Review comment:
This wording, and the wording of the above javadoc, is a big
ambiguous/uncertain. That probably reflects the original ticket's uncertainty.
However, if the original ticket has been thoroughly investigated and is ready
for a code change, then we should have some certainty in the final wording. I
recommend:
```suggestion
Shell.log.warn("The script command is deprecated; use jshell for
scripting instead");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
