DomGarguilo commented on a change in pull request #1965:
URL: https://github.com/apache/accumulo/pull/1965#discussion_r595148282
##########
File path:
core/src/main/java/org/apache/accumulo/core/util/ratelimit/SharedRateLimiterFactory.java
##########
@@ -149,7 +161,7 @@ protected void report() {
}
@Override
- public void acquire(long permits) {
+ public synchronized void acquire(long permits) {
Review comment:
Oh yes, I forgot to make a comment about that but intellij was
displaying a warning "Non-atomic operation on volatile field
'permitsAcquired'". Adding `synchronized` seems to fix this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
