ctubbsii commented on a change in pull request #68:
URL: https://github.com/apache/accumulo-examples/pull/68#discussion_r595512476
##########
File path: pom.xml
##########
@@ -111,6 +106,11 @@
<artifactId>log4j-slf4j-impl</artifactId>
<version>${log4j.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.zookeeper</groupId>
+ <artifactId>zookeeper</artifactId>
+ <version>${zookeeper.version}</version>
+ </dependency>
Review comment:
Dependencies should be ordered alphabetically by groupId, then
artifactId, then scope. I'm not sure why this one moved.
##########
File path: pom.xml
##########
@@ -24,17 +24,17 @@
</parent>
<groupId>org.apache.accumulo</groupId>
<artifactId>accumulo-examples</artifactId>
- <version>2.0.0-SNAPSHOT</version>
+ <version>2.1.0-SNAPSHOT</version>
<name>Apache Accumulo Examples</name>
<description>Example code and corresponding documentation for using Apache
Accumulo</description>
<properties>
- <accumulo.version>2.0.0</accumulo.version>
+ <accumulo.version>2.1.0-SNAPSHOT</accumulo.version>
<eclipseFormatterStyle>contrib/Eclipse-Accumulo-Codestyle.xml</eclipseFormatterStyle>
- <hadoop.version>3.2.1</hadoop.version>
+ <hadoop.version>3.3.0</hadoop.version>
<log4j.version>2.14.0</log4j.version>
- <maven.compiler.release>8</maven.compiler.release>
- <maven.compiler.source>1.8</maven.compiler.source>
- <maven.compiler.target>1.8</maven.compiler.target>
+ <maven.compiler.release>11</maven.compiler.release>
+ <maven.compiler.source>11</maven.compiler.source>
+ <maven.compiler.target>11</maven.compiler.target>
<zookeeper.version>3.4.14</zookeeper.version>
Review comment:
This probably would benefit from a bump in ZK to match Accumulo, also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
