slackwinner commented on a change in pull request #1971:
URL: https://github.com/apache/accumulo/pull/1971#discussion_r599387944
##########
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java
##########
@@ -96,6 +96,7 @@
private ClientInfo info;
private String instanceId;
private final ZooCache zooCache;
+ private static final String VALID_NAME_REGEX =
"^(\\w{1,1024}\\.)?(\\w{1,1024})$";
Review comment:
Sounds good. I'll ensure your suggestions have been applied before
pushing a revised copy soon.
Update: I attempted to remove the max length constants from Constants.java.
However, when I ran Maven, I got an error saying the constants can not be found
in
[FateServiceHandler.java](https://github.com/apache/accumulo/blob/main/server/manager/src/main/java/org/apache/accumulo/manager/FateServiceHandler.java).
Based on the current version, it appears this file heavily relies on the
constants. This is a simple fix but just wanted to point out this detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
