ctubbsii commented on a change in pull request #2068:
URL: https://github.com/apache/accumulo/pull/2068#discussion_r625325698
##########
File path: README.md
##########
@@ -20,11 +20,14 @@ limitations under the License.
[![Build Status][ti]][tl] [![Maven Central][mi]][ml] [![Javadoc][ji]][jl]
[![Apache License][li]][ll]
[Apache Accumulo][accumulo] is a sorted, distributed key/value store that
provides robust,
-scalable data storage and retrieval. With Apache Accumulo, users can store and
manage large
-data sets across a cluster. Accumulo uses [Apache Hadoop]'s HDFS to store its
data and
+scalable data storage and retrieval. With Apache Accumulo, users can store and
manage large data sets across a cluster. Accumulo uses [Apache Hadoop]'s HDFS
to store its data and
Review comment:
Since this section doesn't change any wording, we should keep the
existing 2 lines, rather than merge them into 1.
##########
File path: README.md
##########
@@ -44,13 +47,18 @@ waiting for the tests to run.
This command produces `assemble/target/accumulo-<version>-bin.tar.gz`
+## Contributing
+
+Contributions are welcome to all Apache Accumulo repositories
+
+If you want to contribute, go through our guide [How to
contribute](https://accumulo.apache.org/how-to-contribute/)
+
## Export Control
<details>
<summary>Click here to show/hide details</summary>
----
-
+<br>
Review comment:
This change can be undone.
##########
File path: README.md
##########
@@ -44,13 +47,18 @@ waiting for the tests to run.
This command produces `assemble/target/accumulo-<version>-bin.tar.gz`
+## Contributing
+
+Contributions are welcome to all Apache Accumulo repositories
+
+If you want to contribute, go through our guide [How to
contribute](https://accumulo.apache.org/how-to-contribute/)
Review comment:
```suggestion
Contributions are welcome to all Apache Accumulo repositories.
If you want to contribute, read [our guide on our website][contribute].
```
Can put `[contribute]: https://accumulo.apache.org/how-to-contribute` at the
end.
##########
File path: README.md
##########
@@ -20,11 +20,14 @@ limitations under the License.
[![Build Status][ti]][tl] [![Maven Central][mi]][ml] [![Javadoc][ji]][jl]
[![Apache License][li]][ll]
[Apache Accumulo][accumulo] is a sorted, distributed key/value store that
provides robust,
-scalable data storage and retrieval. With Apache Accumulo, users can store and
manage large
-data sets across a cluster. Accumulo uses [Apache Hadoop]'s HDFS to store its
data and
+scalable data storage and retrieval. With Apache Accumulo, users can store and
manage large data sets across a cluster. Accumulo uses [Apache Hadoop]'s HDFS
to store its data and
[Apache Zookeeper] for consensus. Check out the [Accumulo project
website][accumulo] for
news and general information.
+[Apache Zookeeper] for consensus.
+
+Download the latest version of Apache Accumulo® [here][dl].
+
Review comment:
```suggestion
[Apache Zookeeper] for consensus.
Download the latest version of Apache Accumulo on the [project website][dl].
```
##########
File path: README.md
##########
@@ -100,3 +108,4 @@ more details on bouncycastle's cryptography features.
[tl]: https://github.com/apache/accumulo/actions
[java-export]:
https://www.oracle.com/us/products/export/export-regulations-345813.html
[bouncy-site]: https://bouncycastle.org
+[dl]: https://accumulo.apache.org/downloads/
Review comment:
```suggestion
[dl]: https://accumulo.apache.org/downloads
[contribute]: https://accumulo.apache.org/how-to-contribute
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
