EdColeman commented on a change in pull request #2087:
URL: https://github.com/apache/accumulo/pull/2087#discussion_r629501934
##########
File path: test/src/main/java/org/apache/accumulo/test/ShellServerIT.java
##########
@@ -1421,21 +1431,24 @@ public void help() throws Exception {
}
}
+ // TODO - evaluate this test is testing what is expected or history is
working.
@Test
public void history() throws Exception {
final String table = name.getMethodName();
ts.exec("history -c", true);
ts.exec("createtable " + table);
ts.exec("deletetable -f " + table);
+ // TODO - this may be passing only because method name is history.
ts.exec("history", true, table, true);
+ // TODO - what is this testing?
Review comment:
What I was marking - testing for a table named "history" and a string
"history" seems either redundant - or was trying to test something else. It
could be that the string test was to see that history was returned as part of
the command and when something else besides history is the table name then it
makes more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
