EdColeman commented on a change in pull request #2097:
URL: https://github.com/apache/accumulo/pull/2097#discussion_r631109776
##########
File path: test/src/main/java/org/apache/accumulo/test/ShellServerIT.java
##########
@@ -1431,18 +1436,15 @@ public void help() throws Exception {
}
}
- // TODO - evaluate this test is testing what is expected or history is
working.
@Test
public void history() throws Exception {
- final String table = name.getMethodName();
+ final String table = getUniqueNames(1)[0];
ts.exec("history -c", true);
- ts.exec("createtable " + table);
- ts.exec("deletetable -f " + table);
- // TODO - this may be passing only because method name is history.
+ ts.writeToHistory("createtable " + table);
+ ts.writeToHistory("deletetable -f " + table);
Review comment:
Does the write to history perform an exec() - previously the test was
executing a command, testing the command was successful (via the exec status)
and then that appeared in the history - from a quick look I don't see where
this performs the exec. Not that these commands need tested, but is it a valid
test of shell history?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
