keith-turner commented on issue #947: URL: https://github.com/apache/accumulo/issues/947#issuecomment-839908766
> However, the props maps are only ever generated once, when they are null (see getCustom() and getTableCustom()). Assuming this is correct, this may not be an issue. Yeah I think the caching solves this issue. I also like the caching as it provides a consistent snapshot of those props to plugins. There is a comment that could be removed [here](https://github.com/apache/accumulo/blob/3c039c75ba257c9ff47e0b09be53ef12665ddc74/core/src/main/java/org/apache/accumulo/core/util/ConfigurationImpl.java#L110). Looking at the code in ConfigurationImpl, it seems like it may provide a consistent snapshot of the custom props but not other props. That seems like a wild and wacky user experience (also related to wider discussion I have had w/ @ctubbsii in the past about making all of Accumulo's config operate on consistent snapshots), but if we wanted to address that it would be another issue. I think the comment can be removed and this issue could be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
