jmark99 commented on a change in pull request #2106:
URL: https://github.com/apache/accumulo/pull/2106#discussion_r631940460
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogReader.java
##########
@@ -73,19 +77,37 @@
* @param args
* - first argument is the file to print
*/
- public static void main(String[] args) throws IOException {
+ public static void main(String[] args) throws Exception {
+ new LogReader().execute(args);
+ }
+
+ @Override
+ public String keyword() {
+ return "wal-info";
+ }
+
+ @Override
+ public String description() {
+ return "Prints WAL Info";
+ }
+
+ @SuppressFBWarnings(value = "DM_EXIT",
+ justification = "System.exit is fine here because it's a utility class
executed by a main()")
+ @Override
+ public void execute(String[] args) throws Exception {
Opts opts = new Opts();
- opts.parseArgs(LogReader.class.getName(), args);
+ opts.parseArgs("accumulo wal-info", args);
+ if (opts.files.isEmpty()) {
+ System.err.println("No WAL files were given");
+ System.exit(1);
+ }
Review comment:
The following code will print the message and then display the usage:
```
if (opts.files.isEmpty()) {
JCommander jc = new JCommander(opts);
jc.setProgramName("accumulo wal-info");
System.err.println("No WAL files were given");
jc.usage();
System.exit(1);
}
```
We can do this or merge the current changes and then place a follow-on
ticket to implement Mike's suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
