keith-turner commented on pull request #2096: URL: https://github.com/apache/accumulo/pull/2096#issuecomment-842595041
> I'm curious, do the external compactors support RFile encryption and other RFile-specific configs (like block sizes, locality groups, etc.) today? My guess is that they do, because it's still all the same Accumulo code, just running in a different process, but just curious how much you've exercised those while testing this. The intent is that they should, but not everything has been tested. The [code that actually runs compactions of files](https://github.com/apache/accumulo/blob/90e76cd59e5ed6e08a75020f0d50fe69c4bebee3/server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java#L73) was refactored and moved so that it could be used by tservers and external compactors. So the same code is used, the question is do we always give it the same inputs. Also if compactions were to be highly generalized, some analogue of this code would probably need to be exposed via SPI or API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
