keith-turner opened a new issue #2115:
URL: https://github.com/apache/accumulo/issues/2115


   A simple unit test to ensure client props are reliably converted to a batch 
writer config object could be added for [this 
method](https://github.com/apache/accumulo/blob/af2d2d630094fc06e0ac1d6702a9a49d30ec1e94/core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java#L286)
   
   Maybe refactor the code as follows for unit testing.
   
   ```java
     public static BatchWriterConfig getBatchWriterConfig(Properties props) {
       //take code from existing method
     }
     public BatchWriterConfig getBatchWriterConfig() {
       ensureOpen();
       if (batchWriterConfig == null) {
         batchWriterConfig = getBatchWriterConfig(info.getProperties());
       }
       return batchWriterConfig;
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to