milleruntime commented on a change in pull request #2122:
URL: https://github.com/apache/accumulo/pull/2122#discussion_r641479658



##########
File path: 
core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperations.java
##########
@@ -202,11 +202,32 @@ void removeProperty(String namespace, String property)
    *           if the user does not have permission
    * @throws NamespaceNotFoundException
    *           if the specified namespace doesn't exist
-   * @since 1.6.0
+   * @deprecated since 2.1.0; use {@link #getPropertiesMap(String)} instead.
    */
+  @Deprecated(since = "2.1.0")

Review comment:
       I am wondering if we _need_ to mark this method deprecated. I can't 
think of a risky/harmful reason why a user shouldn't use this method. Yes, a 
map is more convenient, which makes the new method nice but I don't know if we 
need to mark this as deprecated. If a user is using it today there is no reason 
why they should change there code unless they want to.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to