DomGarguilo commented on a change in pull request #2135:
URL: https://github.com/apache/accumulo/pull/2135#discussion_r644300957
##########
File path:
core/src/test/java/org/apache/accumulo/core/clientImpl/ClientContextTest.java
##########
@@ -170,4 +171,58 @@ public void testGetBatchWriterConfigNotUsingDefaults() {
assertEquals(expectedDurability, batchWriterConfig.getDurability());
}
+ @Test
+ public void testGetConditionalWriterConfigUsingDefaults() {
+ Properties props = new Properties();
+ ConditionalWriterConfig conditionalWriterConfig =
+ ClientContext.getConditionalWriterConfig(props);
+ assertNotNull(conditionalWriterConfig);
+
+ // If the value of BATCH_WRITER_TIMEOUT_MAX is set to zero, Long.MAX_VALUE
is returned.
Review comment:
```suggestion
// If the value of CONDITIONAL_WRITER_TIMEOUT_MAX is set to zero,
Long.MAX_VALUE is returned.
```
##########
File path:
core/src/test/java/org/apache/accumulo/core/clientImpl/ClientContextTest.java
##########
@@ -170,4 +171,58 @@ public void testGetBatchWriterConfigNotUsingDefaults() {
assertEquals(expectedDurability, batchWriterConfig.getDurability());
}
+ @Test
+ public void testGetConditionalWriterConfigUsingDefaults() {
+ Properties props = new Properties();
+ ConditionalWriterConfig conditionalWriterConfig =
+ ClientContext.getConditionalWriterConfig(props);
+ assertNotNull(conditionalWriterConfig);
+
+ // If the value of BATCH_WRITER_TIMEOUT_MAX is set to zero, Long.MAX_VALUE
is returned.
Review comment:
There is a second occurrence in this comment that needs to be changed as
well but there isn't a good way to suggest a multi-line change here because the
extra length pushes words onto the next line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
