ctubbsii edited a comment on pull request #2150: URL: https://github.com/apache/accumulo/pull/2150#issuecomment-856878445
There were a few places where #2122 changed the TreeMap to a non-sorted Map: 1. NamespaceOperationsHelper - this is only used for looping to update another data structure, and the order doesn't matter, so this is fine 2. TableOperationsHelper - same as NamespaceOperationsHelper; order doesn't matter, so this is fine 3. TableOperationsHelperTest - does not matter, because the map equality assertion it is checking will succeed whether or not the map is sorted (it only matters that the maps contain the same mapping, regardless of order) 4. Admin class - this one matters for presentation; both printTableConfiguration and printNamespaceConfiguration should use the ImmutableSortedMap.copyOf, to ensure the order is preserved 5. ConfigCommand - this one matters for the shell -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
