foster33 opened a new pull request #2171: URL: https://github.com/apache/accumulo/pull/2171
Fixes #2146 This fix makes the property names regarding write ahead logs uniform. All properties that used `walog` were tagged as deprecated and with a `@ReplacedBy` tag to its respected `wal` replacement. For some uses of the new property names, the `conf.resolve()` function was used in order to read the values from whichever key the user used (whether it be the deprecated or new one). While making these changes I decided to exclude the use of the `resolve` function in the ITs where the new properties were used. From what I understood, there would be no real reason to resolve the usages. There were also some places where Null Pointer Exceptions would occur if they were to be resolved. Please let me know if this was wrong. I also found a section in `HadoopLogCloser` where I did not see a way to properly resolve the usage of the new property name. If this is a place where the resolve function needs to be used please mention it. Lastly, there are places where I create a Property variable `deprecatedProp` in an attempt to make the deprecation suppression area as specific as possible. I am not sure if there is a "cleaner" way of going about this, or if the suppression could be more general. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
