milleruntime commented on a change in pull request #2183:
URL: https://github.com/apache/accumulo/pull/2183#discussion_r661431696
##########
File path: core/src/main/thrift/client.thrift
##########
@@ -22,6 +22,11 @@ namespace cpp org.apache.accumulo.core.clientImpl.thrift
include "security.thrift"
include "trace.thrift"
+// Thrift Id, a wrapper for AbstractId over thrift
+struct Tid {
Review comment:
What about `TAbstractId`? There are places in the code where we use
"tid" for transactionId.
##########
File path:
core/src/main/thrift-gen-java/org/apache/accumulo/core/clientImpl/thrift/TDiskUsage.java
##########
@@ -28,18 +28,18 @@
public class TDiskUsage implements org.apache.thrift.TBase<TDiskUsage,
TDiskUsage._Fields>, java.io.Serializable, Cloneable, Comparable<TDiskUsage> {
private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new
org.apache.thrift.protocol.TStruct("TDiskUsage");
- private static final org.apache.thrift.protocol.TField TABLES_FIELD_DESC =
new org.apache.thrift.protocol.TField("tables",
org.apache.thrift.protocol.TType.LIST, (short)1);
+ private static final org.apache.thrift.protocol.TField
TABLE_NAMES_FIELD_DESC = new org.apache.thrift.protocol.TField("tableNames",
org.apache.thrift.protocol.TType.LIST, (short)1);
private static final org.apache.thrift.protocol.TField USAGE_FIELD_DESC =
new org.apache.thrift.protocol.TField("usage",
org.apache.thrift.protocol.TType.I64, (short)2);
private static final org.apache.thrift.scheme.SchemeFactory
STANDARD_SCHEME_FACTORY = new TDiskUsageStandardSchemeFactory();
private static final org.apache.thrift.scheme.SchemeFactory
TUPLE_SCHEME_FACTORY = new TDiskUsageTupleSchemeFactory();
- public @org.apache.thrift.annotation.Nullable
java.util.List<java.lang.String> tables; // required
+ public @org.apache.thrift.annotation.Nullable
java.util.List<java.lang.String> tableNames; // required
public long usage; // required
/** The set of fields this struct contains, along with convenience methods
for finding and manipulating them. */
public enum _Fields implements org.apache.thrift.TFieldIdEnum {
- TABLES((short)1, "tables"),
+ TABLE_NAMES((short)1, "tableNames"),
Review comment:
Will this cause issues with older RPC calls? Maybe that's OK to
eliminate the ambiguity of "table" since to make it backwards compatible we
would have to keep it around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
