ctubbsii commented on a change in pull request #2186:
URL: https://github.com/apache/accumulo/pull/2186#discussion_r662642718
##########
File path: core/src/test/java/org/apache/accumulo/core/conf/PropertyTest.java
##########
@@ -186,4 +188,61 @@ public void testIsValidTablePropertyKey() {
assertFalse(Property.isValidTablePropertyKey("abc.def"));
}
+
+ /**
+ * PR #2186 eliminated a loop in the computation - this test verifies the
original methods and the
+ * refactor method produce the same result.
+ */
+ @Test
+ public void verifyRefactor() {
+
Review comment:
Okay. Just thinking that after this is merged, "proposed code" doesn't
make sense anymore, because the proposed code becomes the current code. So,
after this is merged, it will look like a test comparing the current
implementation to a previous one that no longer exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
