milleruntime commented on pull request #2181: URL: https://github.com/apache/accumulo/pull/2181#issuecomment-876367995
> Thinking about this a bit, it's a little weird that we can't read a single sorted WAL file. We can read a directory containing one, but we can't read it by itself? That doesn't seem to be a useful restriction for this utility, which is primarily intended to be a troubleshooting utility. This is a restriction of the underlying code, not the utility. The `RecoveryLogsIterator` validates the directory while getting the sorted files to read. This is done here: https://github.com/apache/accumulo/blob/3e765b1f3b487092206cee036097820c37b7907e/server/tserver/src/main/java/org/apache/accumulo/tserver/log/RecoveryLogsIterator.java#L125-L146 > If we pass in a single RFile, I feel like this tool should still be able to read it. That could be done here or in a separate PR, unless there's a reason to not support that at all. Reading a sorted wal RFile that has not completed the sort has limited utility. It will take some refactoring of critical code in the complicated recovery process that may not be worth the trouble. An admin can still use `accumulo rfile-info` on these files to get information about them or read the original WAL to get the whole picture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
