keith-turner opened a new issue #2208:
URL: https://github.com/apache/accumulo/issues/2208


   The static method 
[TabletServer.checkTabletMetadata()](https://github.com/apache/accumulo/blob/f5df4f9681736d35e14b92c58033a1cf062b3d4e/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java#L926)
 is only called by 
[AssignmentHandler](https://github.com/apache/accumulo/blob/f5df4f9681736d35e14b92c58033a1cf062b3d4e/server/tserver/src/main/java/org/apache/accumulo/tserver/AssignmentHandler.java#L106)
 when loading a tablet.   This method could be moved to the AssignmentHandler 
class.  All of the error messages in the methods could be improved to provide 
information that the problems were seen when trying to load a tablet.  For 
example could change the following :
   
   ```java
       if (!extent.equals(meta.getExtent())) {
         log.info("Tablet extent mismatch {} {}", extent, meta.getExtent());
         return false;
       }
   ```
   
   to the following
   
   ```java
       if (!extent.equals(meta.getExtent())) {
         log.info("Saw metadata issue when loading tablet : Tablet extent 
mismatch {} {}", extent, meta.getExtent());
         return false;
       }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to