keith-turner commented on a change in pull request #2225:
URL: https://github.com/apache/accumulo/pull/2225#discussion_r683675526
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader.java
##########
@@ -30,9 +30,30 @@
* complete and then be run again later.
*/
public interface Upgrader {
+
+ /**
+ * Update entries in ZooKeeper - normally runs before the root tablet is
loaded.
+ *
+ * @param ctx
+ * the server context.
+ */
void upgradeZookeeper(ServerContext ctx);
+ /**
+ * Update the root tablet - normally runs after the root tablet is loaded
and before the metadata
+ * table is loaded.
+ *
+ * @param ctx
+ * the server context.
+ */
void upgradeRoot(ServerContext ctx);
+ /**
+ * Update the metadata table - normally runs after the metadata table is
loaded and before loading
Review comment:
```suggestion
* Update the metadata table - called after the metadata table is loaded
and before loading
```
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader.java
##########
@@ -30,9 +30,30 @@
* complete and then be run again later.
*/
public interface Upgrader {
+
+ /**
+ * Update entries in ZooKeeper - normally runs before the root tablet is
loaded.
Review comment:
```suggestion
* Update entries in ZooKeeper - called before the root tablet is loaded.
```
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader.java
##########
@@ -30,9 +30,30 @@
* complete and then be run again later.
*/
public interface Upgrader {
+
+ /**
+ * Update entries in ZooKeeper - normally runs before the root tablet is
loaded.
+ *
+ * @param ctx
+ * the server context.
+ */
void upgradeZookeeper(ServerContext ctx);
+ /**
+ * Update the root tablet - normally runs after the root tablet is loaded
and before the metadata
Review comment:
```suggestion
* Update the root tablet - called after the root tablet is loaded and
before the metadata
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
