Manno15 commented on a change in pull request #2228:
URL: https://github.com/apache/accumulo/pull/2228#discussion_r686932110
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
##########
@@ -748,24 +733,27 @@ private String getRootUserName(SiteConfiguration
siteConfig, Opts opts) throws I
if (opts.cliPassword != null) {
return opts.cliPassword.getBytes(UTF_8);
}
- String rootpass;
- String confirmpass;
+ char[] rootpass;
+ char[] confirmpass;
+ String strrootpass;
+ String strconfirmpass;
do {
- rootpass = getLineReader().readLine(
- "Enter initial password for " + rootUser +
getInitialPasswordWarning(siteConfig), '*');
+ rootpass = System.console().readPassword(
+ "Enter initial password for " + rootUser +
getInitialPasswordWarning(siteConfig));
Review comment:
```suggestion
var rootpass = System.console().readPassword(
"Enter initial password for " + rootUser +
getInitialPasswordWarning(siteConfig));
```
Could do something like this for both passwords and drop the char[] objects
above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
