dlmarion commented on a change in pull request #2238:
URL: https://github.com/apache/accumulo/pull/2238#discussion_r694052055
##########
File path: pom.xml
##########
@@ -566,6 +566,11 @@
<artifactId>slf4j-api</artifactId>
<version>${slf4j.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.yaml</groupId>
+ <artifactId>snakeyaml</artifactId>
+ <version>1.29</version>
+ </dependency>
Review comment:
> This looks too good to be true... please correct me if I'm wrong, but
at first glance, this appears to be a pure Java yaml implementation licensed as
Apache 2.0 without any new transitive dependencies to conflict with.
Yes, that appears to be true:
https://bitbucket.org/asomov/snakeyaml/src/snakeyaml-1.29/pom.xml.
> I'd probably be surprised, however, if commons-configuration2, which is
already on our class path, didn't already support YAML configs.
I have seen snakeyaml get pulled into my other projects usually as a
dependency. In fact, commons-configuration2 uses it in
[YamlConfiguration](https://github.com/apache/commons-configuration/blob/rel/commons-configuration-2.7/src/main/java/org/apache/commons/configuration2/YAMLConfiguration.java).
See also the
[pom](https://github.com/apache/commons-configuration/blob/rel/commons-configuration-2.7/pom.xml#L402).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
