milleruntime commented on pull request #2248: URL: https://github.com/apache/accumulo/pull/2248#issuecomment-906517768
> From a testing standpoint, these changes look good. I did test them locally and ran into no issues. It is still interesting how often that sanity check fails but it is better now that it is a debug statement and not something that kills the thread. I agree. I tested them as well and things seem to run more smoothly. My only concern is that this change is masking an underlying bug that is causing the check to fail. > I like the move of the sanity checks out of the files constructor and doing only one copy of runningJobs. At the very least I think we can keep these changes. The question I have is: do we want to keep failing loudly because there is a bug or is it OK to fail gracefully. I am going to leave this open for now until I can confirm with @keith-turner or find an answer to that question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
