milleruntime commented on pull request #2256: URL: https://github.com/apache/accumulo/pull/2256#issuecomment-910638914
> > A large if or switch statement is almost always a clear indicator of code that needs an OO design. > > There may be an OO design that is easier to understand, I am not sure what it would look like though. I suspect it may need to cut across multiple methods within FileManager but not completely sure. Also not sure how the shared state in FileManager would cleanly interact with this design. Maybe have the different select methods in FileManager return an object instead of boolean. We could have the objects return the next step, similar to how FATE works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
