keith-turner commented on pull request #2256: URL: https://github.com/apache/accumulo/pull/2256#issuecomment-910705139
> We could integrate the CompactionHelper and the selection methods. They seem to go hand and hand (at least in this method): One goal I had was to segregate the code that tracks state (like files compacting, files selected, jobs running, ext compactions running, etc) from code that actually does work (like running compactions and selecting files). Not sure I completely achieved this goal. The Helper may fall more in the do work category and the filemgr may fall more in the state tracking category, but not completely sure. Also not sure if this help you any, just sharing some info. I hope to be able to write unit test for some of the state tracking code that is independent of the code that actually does work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
