EdColeman commented on a change in pull request #2240:
URL: https://github.com/apache/accumulo/pull/2240#discussion_r703622092
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/delete/PreDeleteTable.java
##########
@@ -33,6 +33,11 @@
public class PreDeleteTable extends ManagerRepo {
+ public static String createDeleteMarkerPath(String instanceId, String
tableId) {
Review comment:
Would it be better to use TableId instead of String to strongly type the
parameter? Likely more of a personal preference.
Along the same lines - does using canonical instead of toString provide a
benefit? To me, canonical has a stronger connotation - but current
implementation has same effect. Probably should stick with what would be more
common in the code - canonical appears 289 times in the code according to my
IDE find usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
