Manno15 commented on a change in pull request #2255:
URL: https://github.com/apache/accumulo/pull/2255#discussion_r704603828
##########
File path: test/src/main/java/org/apache/accumulo/test/ShellServerIT.java
##########
@@ -1939,6 +1939,17 @@ public void scans() throws Exception {
ts.exec("deletetable -f t");
}
+ @Test
+ public void scanswithcolon() throws Exception {
Review comment:
```suggestion
public void scansWithColon() throws Exception {
```
##########
File path: test/src/main/java/org/apache/accumulo/test/ShellServerIT.java
##########
@@ -1939,6 +1939,17 @@ public void scans() throws Exception {
ts.exec("deletetable -f t");
}
+ @Test
+ public void scanswithcolon() throws Exception {
+ ts.exec("createtable twithcolontest");
+ make10withcolon();
+ String result = ts.exec("scan -b row0 -c c\\:f:col0 -e row0");
+ assertEquals(1, result.split("\n").length);
+ result = ts.exec("scan -r row0 -c c\\:f:col0");
+ assertEquals(1, result.split("\n").length);
Review comment:
This part does not seem to be working as expected. The excepted value of
1 here is actually the number of lines in the test shell. There will always be
1 here since the inputted command counts as one line. So in theory, the
expected output should be two which isn't the case.
##########
File path: test/src/main/java/org/apache/accumulo/test/ShellServerIT.java
##########
@@ -1939,6 +1939,17 @@ public void scans() throws Exception {
ts.exec("deletetable -f t");
}
+ @Test
+ public void scanswithcolon() throws Exception {
+ ts.exec("createtable twithcolontest");
+ make10withcolon();
Review comment:
With this specific change, I think it is safe to insert a couple of rows
inside the test instead of creating a separate function to create 10. Not a big
deal either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
