milleruntime commented on a change in pull request #150:
URL: https://github.com/apache/accumulo-testing/pull/150#discussion_r704734652
##########
File path: contrib/import-control.xml
##########
@@ -37,18 +37,6 @@
<allow pkg="org.apache.accumulo.core.conf"/>
<allow class="org.apache.accumulo.core.util.threads.ThreadPools"/>
- <!-- TODO refactor code to remove the following exceptions -->
- <allow class="org.apache.accumulo.core.metadata.MetadataTable"/>
- <allow class="org.apache.accumulo.core.replication.ReplicationTable"/>
- <allow class="org.apache.accumulo.core.spi.scan.HintScanPrioritizer"/>
- <allow
class="org.apache.accumulo.core.clientImpl.TabletServerBatchWriter"/>
- <allow class="org.apache.accumulo.core.util.FastFormat"/>
- <allow class="org.apache.accumulo.core.util.Pair"/>
- <allow class="org.apache.accumulo.core.trace.Trace"/>
Review comment:
My guess is that was commented out because either it wasn't working or
the Trace code was in flux (it still is). Since there is an option to use the
Trace in VerifyIngest, we could throw an exception stating it is currently not
supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]