DomGarguilo commented on a change in pull request #2255:
URL: https://github.com/apache/accumulo/pull/2255#discussion_r705554942
##########
File path:
shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java
##########
@@ -285,6 +288,19 @@ protected void fetchColumns(final CommandLine cl, final
ScannerBase scanner,
}
}
+ protected String[] extractColumnFamily(final String columnString) {
Review comment:
> Are referring to that we just take a substring from the last index of
: and that would do it?
Yea what I'm saying is, the substring method you have will correctly handle
all cases so you could remove what is in the else block and allow all cases to
be handled by what you have in the if block. That way there doesnt need to be a
check for how many colons are in the string. @harjitdotsingh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
