dlmarion commented on a change in pull request #2278:
URL: https://github.com/apache/accumulo/pull/2278#discussion_r713187169
##########
File path: core/src/main/java/org/apache/accumulo/fate/Fate.java
##########
@@ -226,11 +223,17 @@ public Fate(T environment, TStore<T> store,
Function<Repo<T>,String> toLogStrFun
* Launches the specified number of worker threads.
*/
public void startTransactionRunners(AccumuloConfiguration conf) {
- int numThreads = conf.getCount(Property.MANAGER_FATE_THREADPOOL_SIZE);
- executor = ThreadPools.createExecutorService(conf,
Property.MANAGER_FATE_THREADPOOL_SIZE);
- for (int i = 0; i < numThreads; i++) {
- executor.execute(new TransactionRunner());
- }
+ final ThreadPoolExecutor pool = (ThreadPoolExecutor)
ThreadPools.createExecutorService(conf,
+ Property.MANAGER_FATE_THREADPOOL_SIZE);
+ fatePoolWatcher = ThreadPools.createGeneralScheduledExecutorService(conf);
Review comment:
That was my concern, that maybe I missed that. However, now that the
creation of that ThreadPool is singularly located in
`ThreadPools.createGeneralScheduledExecutorService`, it should be easy to make
it a singleton that is only created if it does not already exist. It's called
from 33 locations across the code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
