keith-turner commented on issue #2280: URL: https://github.com/apache/accumulo/issues/2280#issuecomment-926331217
> It's primary use case is for implementing a singleton lifecycle for the closeable AccumuloClient, when legacy Instance/Connector APIs are used, so we can clean up the internal AccumuloClient when there are no more legacy Instance/Connector objects in use. I anticipate the SingletonManager class and related complex code will be removed when we remove those deprecated APIs from our code base. That is not quite right. The Instance/Connector code could be removed and we would still need the singleton manager. Its needed to manage singletons in the implementation that were never moved into the client context. Once these singletons are moved into the client context we can remove the SingletonManager. Instance/Connector does not prevent this from movement from happening, its just that no one has ever done the work. If this work were done, I think it would be easy to refactor the Instance/Connector code to use a singleton client context object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
