keith-turner commented on a change in pull request #163:
URL: https://github.com/apache/accumulo-testing/pull/163#discussion_r719829168
##########
File path:
src/main/java/org/apache/accumulo/testing/performance/tests/ScanExecutorPT.java
##########
@@ -89,8 +95,9 @@ public Report runTest(Environment env) throws Exception {
String tableName = "scept";
Map<String,String> props = new HashMap<>();
- props.put(Property.TABLE_SCAN_DISPATCHER_OPTS.getKey() + "executor",
"se1");
- props.put(Property.TABLE_SCAN_DISPATCHER_OPTS.getKey() + "heed_hints",
"true");
+ props.put(Property.TABLE_SCAN_DISPATCHER_OPTS.getKey() + "executor.se1p1",
"se1");
+ props.put(Property.TABLE_SCAN_DISPATCHER_OPTS.getKey() + "executor.se1p2",
"se1");
+ props.put(Property.TABLE_SCAN_DISPATCHER_OPTS.getKey() + "executor.se2p1",
"se2");
Review comment:
If we just set the executor property then that will be the default for
all scan types, so do not need to set it twice. When scan_type equals
dedicated, it will override it to se2.
```suggestion
props.put(Property.TABLE_SCAN_DISPATCHER_OPTS.getKey() + "executor",
"se1");
props.put(Property.TABLE_SCAN_DISPATCHER_OPTS.getKey() +
"executor.dedicated", "se2");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
