dlmarion commented on pull request #2296: URL: https://github.com/apache/accumulo/pull/2296#issuecomment-932154265
I think you are seeing different issues being addressed.These changes do look correct, here's why. 1. [Here](https://github.com/apache/accumulo/commit/e62ace6a9d37572d95999f5412c6148efbba50b9#diff-467b6cb7af0f7b7339d81d3112329b8e19557e685a3c659bc623160826c8f01dL228) I modified Fate.java to use the new ThreadPools class as part of ThreadPools PR. 2. [Here](https://github.com/apache/accumulo/commit/e67ffa0a4be2140234fb3c0ea0742dff192bce91#diff-467b6cb7af0f7b7339d81d3112329b8e19557e685a3c659bc623160826c8f01dL229) includes changes for multiple issues. The change is part of a PR that closes #2272 and #2276. #2272 was an issue that @keith-turner submitted where he noticed that properties marked as mutable were not being honored. Specifically, there were some thread pool properties that were marked as mutable but were either not being resized or were done differently. I consolidated the pool resize logic and updated the code to use it for the ThreadPools that were marked as mutable in a PR for #2278. 3. As part of #2278 I also included a resolution to [this](https://github.com/apache/accumulo/issues/2272#issuecomment-922119524) comment in #2272 . This is where the bug lies. This PR reverts the code changes for # 3 above, keeps the ThreadPool resizing, and ensures that there is a TransactionRunner running for each Thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
