ctubbsii commented on pull request #2297: URL: https://github.com/apache/accumulo/pull/2297#issuecomment-940136884
> @ctubbsii I was thinking more about our comments and was wondering what you think of renaming the classes in the Monitor that get turned into JSON? I noticed that we have a lot of classes in the monitor with generic names, like `Compactions` and `Scans`. These classes contain the variable names for the JSON and if we change will break the front end code. It doesn't make sense to call them `Impl` as we do in other places. What do you think about renaming these classes to something like `CompactionsJSON` or `ScansJSON` to help differentiate it from other back-end classes. JSON wouldn't make sense as part of the name. The objects can be returned as XML also. It's the responsibility of Jackson to decide the presentation format based on the HTTP request. I think the fact that these are data types in the `/rest/` package is sufficient to document the risk of breaking the REST endpoints. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
