keith-turner commented on a change in pull request #2309:
URL: https://github.com/apache/accumulo/pull/2309#discussion_r726590377



##########
File path: 
core/src/main/java/org/apache/accumulo/core/metadata/schema/ExternalCompactionMetadata.java
##########
@@ -54,6 +55,9 @@ public ExternalCompactionMetadata(Set<StoredTabletFile> 
jobFiles, Set<StoredTabl
       TabletFile compactTmpName, String compactorId, CompactionKind kind, 
short priority,
       CompactionExecutorId ceid, boolean propagateDeletes, boolean 
initiallySelectedAll,
       Long compactionId) {
+    if (!propagateDeletes && (kind == CompactionKind.SELECTOR || kind == 
CompactionKind.USER)) {
+      Preconditions.checkArgument(initiallySelectedAll);
+    }

Review comment:
       I updated the check with a message that explains what I was checking for 
in the exception message.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to