DomGarguilo commented on a change in pull request #2324: URL: https://github.com/apache/accumulo/pull/2324#discussion_r734662559
########## File path: server/base/src/main/java/org/apache/accumulo/server/conf/store/PropCacheId.java ########## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.server.conf.store; + +import static org.apache.accumulo.core.Constants.ZCONFIG; +import static org.apache.accumulo.core.Constants.ZNAMESPACES; +import static org.apache.accumulo.core.Constants.ZNAMESPACE_CONF; +import static org.apache.accumulo.core.Constants.ZTABLES; +import static org.apache.accumulo.core.Constants.ZTABLE_CONF; + +import java.util.Comparator; +import java.util.Objects; +import java.util.Optional; +import java.util.StringJoiner; + +import org.apache.accumulo.core.data.NamespaceId; +import org.apache.accumulo.core.data.TableId; +import org.apache.accumulo.fate.zookeeper.ZooUtil; +import org.apache.accumulo.server.ServerContext; +import org.checkerframework.checker.nullness.qual.NonNull; + +public class PropCacheId implements Comparable<PropCacheId> { + + public static final String PROP_NODE_NAME = "encoded_props"; + + // indices for path.split(); + public static final int TYPE_TOKEN_POSITION = 3; + public static final int IID_TOKEN_POSITION = 2; + public static final int ID_TOKEN_POSITION = 4; + + // remove starting slash from constant. + public static final String TABLES_NODE_NAME = ZTABLES.substring(1); + public static final String NAMESPACE_NODE_NAME = ZNAMESPACES.substring(1); + + private final String path; + private final IdType idType; + private final NamespaceId namespaceId; + private final TableId tableId; + + private PropCacheId(final String path, final IdType idType, final NamespaceId namespaceId, + final TableId tableId) { + this.path = path; + this.idType = idType; + this.namespaceId = namespaceId; + this.tableId = tableId; + } + + public static PropCacheId forSystem(final ServerContext context) { + return forSystem(context.getInstanceID()); + } + + public static PropCacheId forSystem(final String instanceId) { + return new PropCacheId(ZooUtil.getRoot(instanceId) + ZCONFIG + "/" + PROP_NODE_NAME, + IdType.SYSTEM, null, null); + } + + public static PropCacheId forNamespace(final ServerContext context, + final NamespaceId namespaceId) { + return forNamespace(context.getInstanceID(), namespaceId); + } + + public static PropCacheId forNamespace(final String instanceId, final NamespaceId namespaceId) { + return new PropCacheId(ZooUtil.getRoot(instanceId) + ZNAMESPACES + "/" + namespaceId.canonical() + + ZNAMESPACE_CONF + "/" + PROP_NODE_NAME, IdType.NAMESPACE, namespaceId, null); + } + + public static PropCacheId forTable(final ServerContext context, final TableId tableId) { + return forTable(context.getInstanceID(), tableId); + } + + public static PropCacheId forTable(final String instanceId, final TableId tableId) { + return new PropCacheId(ZooUtil.getRoot(instanceId) + ZTABLES + "/" + tableId.canonical() + + ZTABLE_CONF + "/" + PROP_NODE_NAME, IdType.TABLE, null, tableId); + } + + public static Optional<PropCacheId> fromPath(final String path) { + String[] tokens = path.split("/"); + + String instanceId = tokens[IID_TOKEN_POSITION]; + + IdType type = extractType(tokens); + + switch (type) { + case SYSTEM: + return Optional.of(PropCacheId.forSystem(instanceId)); + case NAMESPACE: + return Optional + .of(PropCacheId.forNamespace(instanceId, NamespaceId.of(tokens[ID_TOKEN_POSITION]))); + case TABLE: + return Optional.of(PropCacheId.forTable(instanceId, TableId.of(tokens[ID_TOKEN_POSITION]))); + case UNKNOWN: + default: + return Optional.empty(); + } + } + + public static IdType extractType(final String[] tokens) { + // have tokens and ends with PROP_NODE_NAME Review comment: It looks like this comment is the negation of the expression below it. I'm not sure that I understand what the comments purpose is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
