mjwall commented on a change in pull request #2293:
URL: https://github.com/apache/accumulo/pull/2293#discussion_r735174496
##########
File path:
server/gc/src/test/java/org/apache/accumulo/gc/GarbageCollectionTest.java
##########
@@ -532,11 +557,13 @@ public void test() throws Exception {
assertRemoved(gce);
gce = new TestGCE();
+ // adding this causes a failure, what do we need to do with blips?
+ // gce.tableIds.add("1636");
Review comment:
Nothing in the blip code is checking the table ids, so no table ids are
being added to the tableIdsSeen set. That last test adds a blip and sets a
candidate for the blip, then does a collection and asserts it was removed.
The commented line was not in the original test code, I added it before I
moved the table id adds and removes to the TestGCE methods for adding and
removing files and directories.
Removing both those lines, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
